error on pages requiring authentication

[k2soule]

Users who attempt to follow a link to a page that requires authentication, if they are not logged in, should be directed to a page that informs them that the content they are trying to reach requires login (and present a login button). Instead, they see the following error:

[alecpm]

This should be fixed now on isaw4-dev, but I think I'm seeing the same issue on production. The login_form from the WebserverAuth addon expects the login url to contain "login_form" but on these permission redirects it uses "require_login" instead.

[paregorios]

The same issue does indeed occur on production, where we’d been ignoring it since we assumed it would get fixed as part of the upgrade. But somehow it slipped through the cracks.

Is this a fix in code (i.e., it will always be fixed wherever buildout:master gets deployed and run, or do we need to intervene on production so that associated database changes get made?

We can live with it on production for a few more days. But I’d prefer not to have to remember to clean it up after upgrade. Automagically goes away is my preferred experience.

Tom Elliott, Ph.D. Associate Director for Digital Programs and Senior Research Scholar Institute for the Study of the Ancient World (NYU) http://isaw.nyu.edu/people/staff/tom-elliott

On Aug 3, 2015, at 11:19 PM, Alec Mitchell notifications@github.com wrote:

This should be fixed now on isaw4-dev, but I think I'm seeing the same issue on production. The login_form from the WebserverAuth addon expects the login url to contain "login_form" but on these permission redirects it uses "require_login" instead.

— Reply to this email directly or view it on GitHub.

[k2soule]

Thanks, Alex! Can you remove the redundancy? The "Please log in here" message is just fine, but it currently appears twice.

[alecpm]

It's fixed in the repo, so it should apply automatically on production once we've upgraded. It's essentially due to a minor incompatibility between Products.WebServerAuth and the latest Plone.

[alecpm]

The duplicate link was yet another, minor, WebserverAuth incompatibility with the Plone 4.3 theme. Should be fixed now.

[k2soule]

Thanks!

[paregorios]

This seems to have regressed on staging. Try /about/employee/admin-procedures

[alecpm]

I think this will be resolved once @cguardia clears out the custom templates from skins and portal_template_customizations.

[paregorios]

Apparently @cguardia has not yet taken this step on staging in the course of working on #74.

Test: /members/paregorian/foo

I will hold this ticket, marked "reviewing" until #74 is complete, then revisit.

[alecpm]

This is fixed once again. @cguardia had removed the template customizations, but for some reason (which I'm looking into) the skin ordering fixes in the theme profile were not applied during the upgrade/migration.

[paregorios]

seems to be working well now on staging. Can we close this ticket given preceding comment from @alecpm ?

[k2soule]

I'm getting "This page isn't redirecting properly" on dev.

[paregorios]

Huh. My test this morning worked. What URL are you trying to resolve?

[k2soule]

/about/employee/admin-procedures (on the Win7 machine). I'll go check my Mac browsers, to see if the behavior is different.

[paregorios]

I can't reproduce that error. I happily see:

[k2soule]

Hmm. Login redirect is working on my mac. I'll go kick the pc...