make the "Collection Portlet" just like the fixed "related items" portlet: 2pts

isawnyu / isaw.web

Isaw website buildout

http://isaw.nyu.edu

1 stars 3 forks source link

make the "Collection Portlet" just like the fixed "related items" portlet: 2pts #445

Closed paregorios closed 1 year ago

paregorios commented 1 year ago

We would like the "Collection Portlet" to produce output indistinguishable from the output produced by the "related items" portlet once it is fixed per #444. See example page here.

We think there are only two necessary changes:

Include content-item "description" text as specified in #444 for items returned by the referenced collection that have it.
Produce accessibility-and-CSS-friendly HTML as specified in #444.

alecpm commented 1 year ago

@paregorios I've updated the collection portlet on staging to show the description and use more standard markup with a ul.

paregorios commented 1 year ago

@alecpm this is coming along great! See my test here: https://isaw.jazkarta.com/members/paregorian/collection-portlet-test-area/test-page

A couple of things:

We need to manage vertical spacing between portlets. What do we do for other portlets? We should do the same.
I'm happy with font sizes.
For the linked titles, can we use the same style that we use in body text on e.g., pages in main content?
Maybe a bit of whitespace after the description and before the next title?

alecpm commented 1 year ago

I included some CSS changes that should have addressed those issues, but they don't seem to be live. Weird.

alecpm commented 1 year ago

@paregorios Should be looking better now after a CSS registry refresh and a couple more CSS tweaks.

paregorios commented 1 year ago

@alecpm this looks great. I'm happy to see it merged to master and deployed to production

paregorios commented 1 year ago

Perfect on Production(TM)