isawnyu / isaw.web

Isaw website buildout
http://isaw.nyu.edu
1 stars 3 forks source link

create new "tiled view (alt)": 3pts #448

Closed paregorios closed 1 year ago

paregorios commented 1 year ago

As a user with appropriate permissions I will be able to apply a new "tiled view (alt)" that works exactly like the current "tiled view" except:

alecpm commented 1 year ago

OK, I've got a first pass at this up here you should be able to select the Titled Listing (alt) view from the display menu on any Folder, Collection, or Topic. It uses a flex grid that switches from 3 to 2 columns at the mobile breakpoint.

alecpm commented 1 year ago

I'm not quite sure how to handle the :active styling for this large linked box, but the default black background did not seem like a good choice so I've disabled that for now.

paregorios commented 1 year ago

So a few things:

  1. Maybe try white background for the tiles?
  2. The twitching/flickering/text-reflow behavior I'm seeing on mousein and mouseout (106.0.5 (64-bit) on MacOS Monterey 12.6.1) is not going to work for us. If that can't be stabilized with a minimum of further CSS experimentation, then I think we should lose entirely the blue-box-outline and just make the change on the linked title (big bonus) if that behavior and assocaiated click-through behavior could still happen on the entire tile.
alecpm commented 1 year ago

@paregorios white background when active or always white background? I'll see what I can do about flickering, I thought I had it fixed with the padding adjustments I made, but if I can't get it settled I'll try turning off the default border animations for the tile.

alecpm commented 1 year ago

It might also help to make the border always 1px or always 3px.

alecpm commented 1 year ago

FWIW I'm not seeing flickering on Chrome 107.0.5304.87 MacOS Monterey or Safari 16.1 (17614.2.9.1.13, 17614).

paregorios commented 1 year ago

yeah, the border width is probably part of the problem on FF

alecpm commented 1 year ago

@paregorios I've removed the animation around the border switch, which should help with the flicker. However, since I couldn't reproduce it, I can't confirm. Can you let me know if you're still seeing it? You may want to try clearing your browser cache if you are.

paregorios commented 1 year ago

@alecpm I can confirm that the flickering is gone in FF! If you think this is ready to merge and deploy to production, then so do I.

alecpm commented 1 year ago

@paregorios I forgot about Firefox. Not seeing flicker on 106.0.3 (64-bit) with the current implementation.

paregorios commented 1 year ago

yep, it's all good

alecpm commented 1 year ago

FWIW, I implemented the :active styling as a white background for now. The change from the default background to white is probably too subtle for WCAG, but I'm not sure what's best here.

paregorios commented 1 year ago

My sense is that we have enough indicia in the form of the cursor and the underlined title and the blue box around the tile that we meet WCAG for "two indicators"

alecpm commented 1 year ago

@paregorios Good for production then? In that case, I'll merge it and start work on #449 based on this.

paregorios commented 1 year ago

Merge it!

paregorios commented 1 year ago

@alecpm I am attempting to test this functionality on production at https://isaw.nyu.edu/skunkworks/financial-resources, but I do not see the new display listing available on the actions menu. This is after fully dumping cache in my browser and performing a new login.

Screen Shot 2022-11-08 at 3 46 43 PM

alecpm commented 1 year ago

Needed to run an upgrade step. Done.

paregorios commented 1 year ago

Perfect!