isawnyu / isaw.web

Isaw website buildout
http://isaw.nyu.edu
1 stars 3 forks source link

verify no need and remove addon: Products.Maps 3.3 #510

Open paregorios opened 2 months ago

paregorios commented 2 months ago

This addon is currently active in our 4.3 build.

This addon says it is "A new content for displaying Google maps in your site". It appears to add the following archetypes content type:

GeoLocation (Location)

This content type does not seem to be being used anywhere in the site.

Display views

The addon also seems to add a "Map view" display option for Folders and possibly other types. Interaction with the Google Maps API seems to be broken, as only an empty gray map is displayed if you try it out.

Questions

alecpm commented 1 month ago

Currently we use a custom behavior based on Products.Maps on the isaw.bibitems.bibitem "Bibliographic Item" and isaw.exhibition.object "Exhibition Object" type. That behavior is defined in isaw.policy and includes location and pleiades_url fields. Additionally, an eqivalent AT schema extender is applied (conditionally) to the ATCT Document, News Item, and Event types.

The zcml registrations for that behavior and associated views/adapters are conditional on Products.Maps being installed. It should be possible to safely remove the add-on without code changes without causing issues. However, it would be best to add a migration step to remove the custom behavior application from the type FTI's in isaw.policy and also remove the conditional zcml registrations related to this behavior.

Since there is already a dexterity behavior, it should be possible to retain this functionality in Plone 5.2 by upgrading Products.Maps and collective.geolocationbehavior, if desirable.

sauzher commented 1 month ago

@paregorios the only item I found that has a value for pleiadesUrl field is:

https://isaw.nyu.edu/research/amheida/amheida-field-report-2022/ the value is: https://pleiades.stoa.org/places/776235

ad it's rendered so in edit form (geolocations schemata): immagine

(in staging database... i took down Data.fs.old actually)