search

isawnyu / isaw.web

Isaw website buildout
http://isaw.nyu.edu
1 stars 3 forks source link

Get rid of webcouturier.dropdownmenu? #558

Open sauzher opened 3 days ago

sauzher commented 3 days ago

Abandoned: https://github.com/mishunov/webcouturier.dropdownmenu

Is it used in the portal?

I don't see it installed on staging nor it's referred into the basecode.

May this be removed?

@paregorios

paregorios commented 3 days ago

I have no idea about this one. @alecpm any idea?

sauzher commented 3 days ago

I was wrong. There are references in the theme as an override

isaw/theme/browser/template-overrides/webcouturier.dropdownmenu.browser.dropdown_recurse-orig.pt

Still not sure if it's really needed.

sauzher commented 3 days ago

https://github.com/isawnyu/isaw.web/blob/8636e8c9a2e5f50fe1336fcf6f1b986e283188e9/src/isaw.theme/isaw/theme/profiles/default/skins.xml#L27

Here there is a clear removal intention, IMHO

alecpm commented 3 days ago

@sauzher As far as I can tell, we aren't using the add-on in the theme anymore (no obvious dropdown menus in top navigation). So we can probably just uninstall it and remove the browser layer. Dumbarton Oaks appears to be using the add-on under Python 3, so it's not a dealbreaker if we do need to retain it for some functionality.

sauzher commented 2 days ago

Thanks @alecpm, for what I see, in the case, perhaps there will be necessary to convert configlet from formlib into a z3cform one.