some connections are missing in the geojson view

[paregorios]

After the new-style connections roll-out, only those connected places with point geometries in @@connections-json show up on the place map:

http://pleiades.stoa.org/places/579888

{
    "features": [
        {
            "geometry": {
                "type": "Polygon",
                "coordinates": [
                    [
                        [
                            24.027097,
                            38.220427
                        ],
                        [
                            24.027098,
                            38.223418
                        ],
                        [
                            24.028009,
                            38.222727
                        ],
                        [
                            24.027097,
                            38.220427
                        ]
                    ]
                ]
            },
            "type": "Feature",
            "id": "580097",
            "properties": {
                "snippet": "Settlement; 550 BC - AD 300",
                "link": "http://pleiades.stoa.org/places/580097",
                "description": "Rhamnous was an ancient settlement of Attica adjacent to the Euboean Strait.",
                "location_precision": "precise",
                "title": "Rhamnous"
            }
        },
        {
            "geometry": {
                "type": "LineString",
                "coordinates": [
                    [
                        23.804698,
                        37.82377
                    ],
                    [
                        23.804988,
                        37.836261
                    ]
                ]
            },
            "type": "Feature",
            "id": "579863",
            "properties": {
                "snippet": "Settlement; 550 BC - AD 300",
                "link": "http://pleiades.stoa.org/places/579863",
                "description": "Anagyrous was a deme of ancient Attica.",
                "location_precision": "precise",
                "title": "Anagyrous"
            }
        },
        {
            "geometry": {
                "type": "LineString",
                "coordinates": [
                    [
                        23.993749,
                        37.926212
                    ],
                    [
                        23.993752,
                        37.926166
                    ]
                ]
            },
            "type": "Feature",
            "id": "579879",
            "properties": {
                "snippet": "Temple; 750 BC - AD 640",
                "link": "http://pleiades.stoa.org/places/579879",
                "description": "A sacred site in Attica dedicated to Artemis Brauronia. The sanctuary is active from the Middle Bronze Age period, although a gap in activity stretches from the Final Bronze Age to the eighth century B.C.",
                "location_precision": "precise",
                "title": "Artemis Brauronia, T."
            }
        },
        {
            "geometry": {
                "type": "Point",
                "coordinates": [
                    23.374906,
                    38.179685
                ]
            },
            "type": "Feature",
            "id": "540756",
            "properties": {
                "snippet": "Settlement, Fort; 750 BC - 330 BC",
                "link": "http://pleiades.stoa.org/places/540756",
                "description": "A city of northern Attika at the boundary of Boeotia, Eleutherai is one of the best preserved ancient fortresses in Attika.",
                "location_precision": "precise",
                "title": "Eleutherai"
            }
        },
        {
            "geometry": {
                "type": "Polygon",
                "coordinates": [
                    [
                        [
                            23.900453,
                            38.095615
                        ],
                        [
                            23.88595,
                            38.103986
                        ],
                        [
                            23.895761,
                            38.106141
                        ],
                        [
                            23.900453,
                            38.095615
                        ]
                    ]
                ]
            },
            "type": "Feature",
            "id": "579958",
            "properties": {
                "snippet": "Settlement, Temple, Theatre, Plaza; 550 BC - AD 300",
                "link": "http://pleiades.stoa.org/places/579958",
                "description": "An ancient settlement and deme of Attica.",
                "location_precision": "precise",
                "title": "Ikarion"
            }
        }
    ],
    "title": "Attica",
    "bbox": [
        23.374906,
        37.82377,
        24.028009,
        38.223418
    ],
    "type": "FeatureCollection",
    "id": "579888",
    "description": "Historical region of Greece, centered on the Attic peninsula."
}

The user expectation is that there should be a connection symbol for each connection. The obvious solution seems to be to refactor @@connections-json so it uses the "representative point" for each connected place, rather than the bounding geometry.

[davisagli]

The connections in the json are there on the map; it's just that it's hard to see the ones that are not points because they display a shape rather than an icon, and it's small when zoomed out. I think it makes sense to use the representative point for connected places rather than the actual geometry, but that's a new feature request, not a regression, right?

A different problem is that the json doesn't include all of the connections listed on the page. I'm looking into that one now.

[paregorios]

@davisagli should we make this ticket just about the missing stuff in the json, and create a separate story for the visualization issue?

[davisagli]

Sure.

When logged in the only one missing from the json is http://pleiades.stoa.org/places/585903, which is expected because it's unlocated.

[davisagli]

When logged out, http://pleiades.stoa.org/places/560221 is missing because its only precise location is in drafting, so it falls back to determining the repr point using connected places, and that fails on something with "No gridsquare c5 in map 60"

[davisagli]

When logged out, http://pleiades.stoa.org/places/606653928 is missing because it's in the drafting state. This reveals two bugs with the new connections: 1. if a connection object is published that references a place that is not published, it is shown to anonymous users, and 2. in the same scenario, a logged-in user does not see any indication that the connection refers to a place in drafting.

[paregorios]

I have created Scrumdo Story #66: use representative point for position of all connections on place maps for the visualization aspects of this ticket. I will next retitle this ticket to reflect the narrowing of its scope to missing items in the geojson.

[davisagli]

Why http://pleiades.stoa.org/places/579885 is missing is a fun one. When adding a marker for a roughly located connected place, the connections-json view searches for getId=[id of connected place]. Well, the new connection object has the same id, so in some cases its finding the connection rather than the place, and the connection has no inherent geometry of its own. Will fix by also specifying portal_type='Place' in the query.

[alecpm]

Regarding the first issue (of published connections referencing drafting locations), I believe we discussed this possibility a bit, but don't recall the outcome of that discussion. In the end though, it probably doesn't make sense to show users links to content they can't actually view.

[davisagli]

Even with the fix I mentioned, http://pleiades.stoa.org/places/579885 is not showing up for anonymous users, and I'm stuck trying to figure out why. I'll come back to that one another time.

[davisagli]

This is working much better (on staging) now that Alec implemented story 66 to show the representative point for connections, and with my fix from #143 so that wrong cap grids don't get in the way of locating a place by other means.

I think the only remaining thing we need to work on is what to do with connections where the Connection itself is published but the Place it refers to is not. Currently these are included in the connections list but do not show up on the map. I agree with Alec that we probably should not show these links to anonymous users. @paregorios do you agree?

[paregorios]

@davisagli and @alecpm my inclination is to hide connections from unpublished places and to unpublished places from anonymous viewers. Authenticated viewers should be allowed to see them, even if they don't have permission to view the contents of the item (prevent duplicate creations). Make sense?

[davisagli]

Yeah, that makes sense to me.

[alecpm]

For the example Place above, I'm seeing two missing connections at this point. I think I understand why those specific ones are missing and perhaps we can decide how to handle similar cases going forward based on that.

1) Drymos: http://pleiades.stoa.org/places/585903 - has only a single location with no coordinates. The only point from which the geometry is derived is the one connection to Attica.

2) Daphni Monastery: http://pleiades.stoa.org/places/606653928 - has a location with coordinates, but that location is private. Because we are using the catalog metadata to derive representative point for connections, I believe that data point is not available (since the catalog metadata is not permission aware). This Place also has only one connection (to Attica), which is the only published item from which its location can be derived.

I'll need to do a little investigation as to why these aren't at least showing up on top of the representative point for Attica (perhaps there's an attempt to avoid recursion in the representative point calculation that leaves these out). In general though, the most efficient way to derive a representative point for each connection is to use the catalog metadata value for the place, which will only take into account published locations/connections.

[paregorios]

So there are two concerns here:

1. What to show in the "connections" lists on place view (varies between anonymous and authenticated)
2. What to show in the map on place view

I want to make sure we don't get these two concerns conflated.

I'll try to summarize again what I want to see in each case here in bit. Meantime, taking ownership of this ticket so I don't lose the todo in the shuffle.

[paregorios]

still needs my attention