search

isawnyu / pleiades-gazetteer

This repository provides a home for tickets and other planning documents for the Pleiades gazetteer of ancient places. Code is kept in multiple other repositories.
https://pleiades.stoa.org
11 stars 0 forks source link

recent map on "about" page not working in chrome #283

Open paregorios opened 7 years ago

paregorios commented 7 years ago

https://pleiades.stoa.org/home

Seems to be due to mixed content blocking. The page is served over HTTPS, but leaflet.css seems to be referenced via an http url. In chrome, if one chooses to "load unsafe scripts", the map appears. Apparently our previous dragnet to move over to HTTP was not as comprehensive as we thought.

davisagli commented 7 years ago

Looks like these links were changed to protocol-relative URLs (starting with //) in https://github.com/isawnyu/pleiades-notredame/blob/master/pleiades/notredame/skins/pleiades_notredame_custom_templates/home.pt#L12 but in the production site that's getting overridden by a template stored in the ZODB which doesn't have those fixes: https://pleiades.stoa.org/home/manage_workspace

paregorios commented 7 years ago

@davisagli thanks, I'll have a look at that

paregorios commented 7 years ago

For the short run, I'm going to intervene in the ZMI-override version to resolve the immediate problem. There are some other issues with the template in general that I'll undertake to address in code. Once that's done, the override can be eliminated entirely.

paregorios commented 7 years ago

Overriding template has been modified and map now appears. Have made to-do to create new ticket for next steps.

skleinfeldt commented 7 years ago

@paregorios reading the initial description - given the move towards expecting everything to be https, not just login pages, perhaps you should think about a long range plan for that. (No idea if it affects this ticket.) https://security.googleblog.com/2016/09/moving-towards-more-secure-web.html.

paregorios commented 7 years ago

@skleinfeldt thanks, yes that's where I'm trying to go, and for that reason. iirc, we took that step with scrumdo story 76. This is cleanup.

skleinfeldt commented 7 years ago

Ah, so "our previous dragnet to move over to HTTP" should have said HTTPS? That makes more sense!

paregorios commented 7 years ago

Typos. They will end us.

-- Tom Elliott, Ph.D. Associate Director for Digital Programs and Senior Research Scholar Institute for the Study of the Ancient World (NYU) http://isaw.nyu.edu/people/staff/tom-elliott

On Fri, Feb 10, 2017 at 11:11 AM, Sally Kleinfeldt <notifications@github.com

wrote:

Ah, so "our previous dragnet to move over to HTTP" should have said HTTPS? That makes more sense!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/isawnyu/pleiades-gazetteer/issues/283#issuecomment-279003037, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQEdZzdUTn8w6u9PNlDsYaB4b0H3zR0ks5rbJo8gaJpZM4L9SD8 .

paregorios commented 5 years ago

I need to review this to see if there's still an override in place and then taskify getting rid of it if need be.

paregorios commented 5 years ago

This is long since fixed. closing.

paregorios commented 5 years ago

wooops, wrong ticket reopening