isax5 / Hymnal-Xamarin

New version of the adventist hymnal multi-platform and multi-language
18 stars 7 forks source link

Feature request - make number entry more efficient #213

Closed granola7 closed 2 years ago

granola7 commented 2 years ago

When switching between hymns, it takes a lot of extra keypresses - push the back button, click on the number entry field, backspace out the current number, enter in the new number, press Open.

I'll submit a pull request for a few changes I made: a) When clicking on the number entry field, it automatically selects the current number so you can just overwrite it, without having to backspace b) When clicking Return in the keyboard, it does the same as clicking Open c) Unrelated bugfix - I changed the minimum hymn number from 0 to 1. Right now, you'll get an error message if you try to open hymn #0.

I tested these changes on Android, but I don't have an iPhone for testing.