search

isbm / berrymill

Think of it as Kiwi++
MIT License
2 stars 5 forks source link

replace prints with kiwi.logger #44

Closed osab270844 closed 10 months ago

osab270844 commented 10 months ago

replace prints with kiwi.logger.

wintron04 commented 10 months ago

You have to change some of the test to capture the correct output. However this is already done and completed on PR #41 I would suggest just closing this PR

osab270844 commented 10 months ago

@wintron04 but still some prints are not replaced in your PR, e.g. https://github.com/isbm/berrymill/pull/41/files#diff-f7a231c65287e1d3c4ad3023ad39303ee5356c17e2f1a8f392813b31a492ed36L18

osab270844 commented 10 months ago

I'm checking the tests output capture right now.

osab270844 commented 10 months ago

replaced by https://github.com/isbm/berrymill/pull/45 to rebase the log-fixes branch.