add defaults to ArrayEnumerable constructor

isc30 / linq-collections

Strongly typed Linq and Collections implementation for Javascript and TypeScript (ECMAScript 5)

https://www.npmjs.com/package/linq-collections

MIT License

119 stars 12 forks source link

add defaults to ArrayEnumerable constructor #41

Closed KubaSzostak closed 6 years ago

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling bfe41935bf9a8137e8a888911484da69ef31ff88 on KubaSzostak:patch-1 into d694995ce68683581ab773ea66a45c0892cf826a on isc30:master.

isc30 commented 6 years ago

ArrayEnumerable is part of the implementation details, its never exposed to the end user. I can't find any place where this default value would be used, can you justify this change? Thanks a lot for contributing

KubaSzostak commented 6 years ago

I missed Enumerable.fromSource(). I was looked for such method in List implementation. You're right - there is no need for changing ArrayEnumerable constructor.