search

isce-framework / fringe

Fine Resolution InSAR With Generalized Eigenvectors (FRInGE)
Apache License 2.0
81 stars 42 forks source link

support VRT file input for sequential --bbox #17

Closed yunjunz closed 4 years ago

yunjunz commented 4 years ago

This PR adds support of VRT file for sequential.py --bbox option, besides the existing input style.

It also fixes some typo and broken links in the document.

piyushrpt commented 4 years ago

I see this is for the case when a cropped VRT has already been setup, correct? That way, you don't have to remember the box limits all the time for every command. Am I interpreting this correctly?

yunjunz commented 4 years ago

Yes, exactly @piyushrpt.

hfattahi commented 4 years ago

I think, we have tried to minimize dependencies (at least for core fringe modules). Isce is a significant dependency to add just to get the xml files which are not needed anywhere in fringe. I suggest to eleminate gdal2isce_xml.py commands. A user can always run that later if needed.

yunjunz commented 4 years ago

Thank you @hfattahi for the suggestion, I did not realize that isce is not a dependency here. Besides the gdal2isce_xml.py call, I will also comment out the isceobj.Util.ImageUtil.ImageLib call here introduced in #14 then, otherwise, the script will return error if no XML file exists.

dbekaert commented 4 years ago

Perhaps we should then also remove ISCE2 from the conda suggested dependency under install guidelines?

It is not mentioned in the prerequisite but included it explicitly says that isce2 should be installed in the macOS and conda example. Same applies for the PATH exports. For now i had it included in the cricleCI build i am setting up, but i can remove it again.

see here: https://github.com/isce-framework/fringe/blob/master/docs/install.md