search

isce-framework / fringe

Fine Resolution InSAR With Generalized Eigenvectors (FRInGE)
Apache License 2.0
80 stars 42 forks source link

WIP: Ci #51

Closed hfattahi closed 3 years ago

hfattahi commented 3 years ago

This PR is an attempt to fix the build on circle-ci. On linux machine I got same error message as reported in circle-ci, which was a complain about not being able to find OpenMP. Additionally, for me cython from conda was not detected unless I follow the same change in https://github.com/isce-framework/fringe/pull/20. Simply adding -DCMAKE_PREFIX_PATH=$CONDA_PREFIX to the cmake command was not helpful. Happy to hear better solutions.

I have narrowed the python version in the environment yaml file. This setup was successful locally. Will relax the python version once I see the ci builds sucessfully.

yunjunz commented 3 years ago

I would suggest renaming requirements_linux.yml to environment_linux.yml for the convention consistency.

What's the rationale for removing the requirements_linux.txt file? It provides an alternative choice and can not be replaced the yml file, which constrains the user to create a new environment.

hfattahi commented 3 years ago

I would suggest renaming requirements_linux.yml to environment_linux.yml for the convention consistency.

What's the rationale for removing the requirements_linux.txt file? It provides an alternative choice and can not be replaced the yml file, which constrains the user to create a new environment.

Renaming sounds good. Will do.

I don't think if we should keep multiple environment files floating around. Specially that it did not work on circle-ci and did not work for me locally. I guess a user can always copy those few lines to a new environment files if they want to.