isce-framework / fringe

Fine Resolution InSAR With Generalized Eigenvectors (FRInGE)
Apache License 2.0
80 stars 42 forks source link

Error in unwrap_fringe.py #52

Closed vbrancat closed 3 years ago

vbrancat commented 3 years ago

unwrap_fringe.py fails when using SNAPHU unwrapper. The code fails because of non-existent metadata/XML file. Below an error report:

This is the Open Source version of ISCE.
Some of the workflows depend on a separate licensed package.
To obtain the licensed package, please make a request for ISCE
through the website: https://download.jpl.nasa.gov/ops/request/index.cfm.
Alternatively, if you are a member, or can become a member of WinSAR
you may be able to obtain access to a version of the licensed sofware at
https://winsar.unavco.org/software/isce
length, width:  1217   7620
Traceback (most recent call last):
  File "/home/vbrancat/Fringe/install/bin/unwrap_fringe.py", line 182, in <module>
    unwrap_snaphu(inps, length, width, metadata)
NameError: name 'metadata' is not defined

The issue popped up when I updated my main branch. At glance, the issue seems to be related to abug related to the merge of PR #45. Particularly, the bug is at line https://github.com/isce-framework/fringe/blob/67483e9eb6480f6d3970d2f5ce310205c9feeadc/python/unwrap_fringe.py#L105 where I think metadata should be set to Noneby default

@hfattahi @bjmarfito