isce-framework / isce2

InSAR Scientific Computing Environment version 2
Other
512 stars 252 forks source link

Alos2Proc fails due to Geozero change #320

Closed EJFielding closed 3 years ago

EJFielding commented 3 years ago

It seems that the recent changes to Geozero (https://github.com/isce-framework/isce2/pull/302) might require the Alos2Proc code to be updated.

  File "/u/pez0/fielding/tools/ISCE2_test/install/isce/applications/alos2App.py", line 1173, in <module>
    insar.run()
  File "/u/pez0/fielding/tools/ISCE2_test/install/isce/components/iscesys/Component/Application.py", line 142, in run
    exitStatus = self._processSteps()
  File "/u/pez0/fielding/tools/ISCE2_test/install/isce/components/iscesys/Component/Application.py", line 405, in _processSteps
    result = func(*pargs, **kwargs)
  File "/u/pez0/fielding/tools/ISCE2_test/install/isce/components/isceobj/Alos2Proc/Factories.py", line 40, in __call__
    return self.method(self.other, *args, **kwargs)
  File "/u/pez0/fielding/tools/ISCE2_test/install/isce/components/isceobj/Alos2Proc/runGeocode.py", line 68, in runGeocode
    geocode(referenceTrack, demFile, inputFile, bbox, numberRangeLooks, numberAzimuthLooks, interpMethod, 0, 0)
  File "/u/pez0/fielding/tools/ISCE2_test/install/isce/components/isceobj/Alos2Proc/runGeocode.py", line 123, in geocode
    topo.geocode()
  File "/u/pez0/fielding/tools/ISCE2_test/install/isce/components/zerodop/geozero/Geozero.py", line 231, in geocode
    geozero.geozero_Py(demAccessor,
TypeError: function takes exactly 9 arguments (8 given)
EJFielding commented 3 years ago

I looked at the Alos2Proc/runGeocode.py code and it is setting the lookSide parameter. topo.lookSide = pointingDirection[track.pointingDirection]

I thought may the problem was only in the scons files that did not recompile the Alos2Proc code because it did not recognize the dependency. I tried removing my whole build and install directories to force a complete rebuild, but it still fails.

EJFielding commented 3 years ago

@yunjunz Thanks! Yes, that fixed it.

zhuhaxixiong commented 2 years ago

i can not download waterbody mask in step download dem