isce-framework / s1-reader

Sentinel-1 reader
Apache License 2.0
27 stars 12 forks source link

added burst plotting script #45

Closed otirmizi closed 2 years ago

otirmizi commented 2 years ago

The new script reads info from the SLC and outputs a .csv file containing burst IDs and other metadata. The script also outputs an interactive html file of the plotted bursts as well as a shapefile of the GeoDataframe

hfattahi commented 2 years ago

Sorry for commenting again even though I approved. It seems like kml comes for free with what you already have. All you need to do is:

import fiona
fiona.supported_drivers['KML'] = 'rw'
gdf2.to_file('burst_map.kml', driver='KML')

That would make the kml which you can open in google earth. Here is a screenshot:

Screen Shot 2022-05-24 at 12 54 15 PM

Do you mind adding those few lines.

LiangJYu commented 2 years ago

@otirmizi You also need to check the Codacy report at the bottom of the PR page if it flags anything. image

LiangJYu commented 2 years ago

@otirmizi You also need to check the Codacy report at the bottom of the PR page if it flags anything.

Just because something is flagged doesn't mean it needs or can be fix/addressed. LMK if you have any questions.

LiangJYu commented 2 years ago

Hit "Squash and merge". image

Maybe clean up nit-pick related bullets, then "Confirm squash and merge" and aoilà. image

otirmizi commented 2 years ago

@LiangJYu I don't have write access so that option is not showing up for me :/

image

LiangJYu commented 2 years ago

@LiangJYu I don't have write access so that option is not showing up for me :/

image

I'll merge this PR. I didn't know you lack write access. 🤷