Closed hfattahi closed 2 years ago
Note if you want to try the PR you need to manually change this path : https://github.com/opera-adt/s1-reader/pull/47/files#diff-b5dff69ea64ed4cad7618ae751ba33cd24982292374cb3ebf6d548f99ed2a6f4R15
Thanks @LiangJYu for the review. The commits above should address your comments. Note that I did not accept your suggestion to change the track number definition to start from 0. That would cause inconsistency and can be a source of future bugs.
ESA just released the burst map today which can be found here. My initial evaluation showed that we are using the same algorithm. The only difference was that our IDs were computed locally or to be more precise they were computed for each track and not globally. I evaluated the ESA global burst map and extracted the adjustments needed to be added to our computed burst IDs to make our IDs consistent with ESA burst map and at the same time make our IDs referenced to the first burst of the first track.
Below are screenshots for one burst over Miami from both ESA burst map and s1-reader derived ID. With this PR the IDs for this specific burst in ESA map is "048 101101 IW3" and in our S1-reader is "t48_101101_iw3" which are consistent.
To do: I need to find the best way where to store the .txt file in this PR and what would be the right way to call it.