Closed seongsujeong closed 2 years ago
Thank you all for valuable feedback. I revised the code as much as I could based on the comments posted here. One last thing I would like to discuss is what data type would be the best for Sentinel1BurstSlc.ipf_version
. Please see the the comments below for the detail.
https://github.com/opera-adt/s1-reader/pull/48#discussion_r927925747
I am inclined to packaging.version.Version
. for the version information (and accept the suggestion by @LiangJYu ), but any comments and suggestion are appreciated.
Thanks @LiangJYu @gshiroma for the wonderful suggestions and information to improve the code. I think the code is ready to review.
Thank you all for the inputs for this PR. I've updated the branch to date to test it before merging it into the main repo. Looks like pytest in CircieCI is failing, with the error summary below:
=============================================== short test summary info =============================================== ERROR tests/test_bursts.py::test_burst - KeyError: "There is no item named 'manifest.safe' in the archive" ERROR tests/test_orbit.py::test_orbit_datetime - KeyError: "There is no item named 'manifest.safe' in the archive" ERROR tests/test_reader.py::test_burst_from_zip - KeyError: "There is no item named 'manifest.safe' in the archive"
I've taken a look at the test data .../tests/data/S1A_IW_SLC__1SDV_20200511T135117_20200511T135144_032518_03C421_7768.zip
, and found that the file manifest.safe
is missing in the .zip file.
This PR includes updates on s1_reader.py
that reads IPF version from the manifest.safe
file. I wonder if someone can commit a new .zip file for the test data that has the file.
I also forgot to ask you to please resolve the codacy issues.
Nevermind. I just noticed you did that yesterday. Thanks!
Thank you all for the inputs for this PR. I've updated the branch to date to test it before merging it into the main repo. Looks like pytest in CircieCI is failing, with the error summary below:
=============================================== short test summary info =============================================== ERROR tests/test_bursts.py::test_burst - KeyError: "There is no item named 'manifest.safe' in the archive" ERROR tests/test_orbit.py::test_orbit_datetime - KeyError: "There is no item named 'manifest.safe' in the archive" ERROR tests/test_reader.py::test_burst_from_zip - KeyError: "There is no item named 'manifest.safe' in the archive"
I've taken a look at the test data
.../tests/data/S1A_IW_SLC__1SDV_20200511T135117_20200511T135144_032518_03C421_7768.zip
, and found that the filemanifest.safe
is missing in the .zip file. This PR includes updates ons1_reader.py
that reads IPF version from themanifest.safe
file. I wonder if someone can commit a new .zip file for the test data that has the file.
I'm working this and will submit a PR to this branch sometime today.
The scope of the fix grew being adding manifest.safe so I issued a new PR to main instead of to your PR. See #58
The scope of the fix grew being adding manifest.safe so I issued a new PR to main instead of to your PR. See #58
Also left a commend on the PR #58, but confirmed that CircleCI passed. Thank you for the update on the unit test!
This PR implements the reader for Calibration Annotation Data Set (CADS), and Noise Annotation Data Set (NADS), which was related to the issue #27. This work is in context of implementing thermal noise correction. The structure of CADS and NADS are very similar, so their readers shares similar procedure to read. Therefore the readers are implemented together in
s1_annotation.py
Few examples of the usage are as below:
Notes:
rg
, and the ones about the azimuth noise vector hasaz