Thermal noise Correction and EAP phase compensation

isce-framework / s1-reader

Sentinel-1 reader

Apache License 2.0

27 stars 12 forks source link

Thermal noise Correction and EAP phase compensation #62

Closed seongsujeong closed 2 years ago

seongsujeong commented 2 years ago

This PR is to add thermal noise correction and EAP phase compensation features into OPERA workflow.

Few more enhancements implemented for exporting LUT for thermal noise correction to deal with the format difference of NADS w.r.t. IPF version
Prototype implementation for EAP correction

seongsujeong commented 2 years ago

Thank you @LiangJYu for reviewing this PR. I've accepted / applied your suggestions and comments as above.

seongsujeong commented 2 years ago

Realized that the changes on the code has made the CircleCI test to fail. Now working on fixing that.

seongsujeong commented 2 years ago

Realized that the changes on the code has made the CircleCI test to fail. Now working on fixing that.

Done.

seongsujeong commented 2 years ago

Thank you @LiangJYu for all of your comments and suggestions. I think I've addressed all of your comments, and the PR is ready for another look if you have time. I appreciate your help :)

seongsujeong commented 2 years ago

@LiangJYu @gshiroma Thanks for your comments and suggestions to improve this PR. Please let me know if you have any other concerns in the code.

gshiroma commented 2 years ago

Thank you, @seongsujeong , for addressing all my comments. I have one last suggestion below, but I think this PR is already good for merging.

Ah.. Just please make sure to resolve all conflicts before merging it.