isce-framework / s1-reader

Sentinel-1 reader
Apache License 2.0
27 stars 12 forks source link

s1_reader: refactor track_burst_num + optional noise + add safe_filename #70

Closed yunjunz closed 2 years ago

yunjunz commented 2 years ago
yunjunz commented 2 years ago

Thanks @yunjunz for these fixes. I have not tested the PR yet (I am planning to do that pretty soon). In the meantime, I have left a couple of comments. The most important is related to how the logging of the warning messages is performed. At the moment, we are using pyre inherited from ISCE3.

I see both print() and warnings.warn() are currently used in s1_burst_slc.py. In _burst_from_zip(), there is no message at all, if no TIFF file found (https://github.com/opera-adt/s1-reader/blob/71e2c9e589f9e010b4952a574fcda83806561339/src/s1reader/s1_reader.py#L644); while in _burst_from_zip() as modified in this PR, I changed it from warning.warn() to print().

My main motivation is that: a lot of these warnings while testing with metadata only (downloaded from asfsmd) are annoying and not helpful.