Adding EMCF solver - Githubissues

isce-framework / spurt

Spatial and Temporal phase Unwrapping for InSAR time-series

https://spurt.readthedocs.io/

Apache License 2.0

20 stars 4 forks source link

Adding EMCF solver #10

Closed piyushrpt closed 4 months ago

piyushrpt commented 5 months ago

Unwrapping in time first and then in space
Support for computing residues and flood filling using gradients
Support for including models when computing residues
Example usage can be found in tests/workflows/test_emcf.py

piyushrpt commented 5 months ago

I will leave this branch till @gmgunter gets a chance to take a better look. No rush. The feature branch should be fully functional.

piyushrpt commented 4 months ago

I think the comments here have come in a little too late to address them satisfactorily and not impact the two other PRs that are queued up. I can included them in the last of the PRs that are stringed together. Does that work?

gmgunter commented 4 months ago

Does that work?

Yeah, that's totally fine with me. I'll continue adding comments as I read through the changes, but they can be addressed in subsequent PRs. I'll approve each of the backlog PRs once I'm finished reviewing it, even if there are remaining comments, until I'm caught back up with you.