search

isce-framework / spurt

Spatial and Temporal phase Unwrapping for InSAR time-series
https://spurt.readthedocs.io/
Apache License 2.0
20 stars 4 forks source link

Add docs requirements to `pyproject.toml` #22

Closed scottstanie closed 3 months ago

scottstanie commented 3 months ago

I didn't notice that it didn't have the docs optional install in the pyproject.toml, which caused the readthedocs build to fail

I moved all the requirements into requirements.txt files in their respective folders.

scottstanie commented 3 months ago

LGTM, although I'd just as soon keep these lists of dependencies in the pyproject.toml file. Is there any reason to prefer moving them to requirements.txt files? It seems kind of nice to keep them all in one place and avoid cluttering the repo with additional config files.

Sounds like a good idea- I don't think the slight familiarity benefit from having requirements.txt files outweighs the downside of 3 more config files

scottstanie commented 3 months ago

docs built correctly now: https://spurt.readthedocs.io/en/latest/ ~let me know if there's any issues for you all to access the admin panel too~: https://readthedocs.org/dashboard/spurt/edit/ you probably can't access until i add you, so please post your readthedocs names (e.g. Geoff)