isce-framework / spurt

Spatial and Temporal phase Unwrapping for InSAR time-series
https://spurt.readthedocs.io/
Apache License 2.0
22 stars 4 forks source link

Fix out of order uw data from `as_completed` shuffling #28

Closed scottstanie closed 4 months ago

scottstanie commented 4 months ago

I had been still getting the AssertionError: Arrays differ by non-integer cycles problem when trying to tile. I tracked this when I wrote out each spatial unwrapping result to a numpy array within the future, it perfectly matched the spurt CLI. But then the HDF5 saved data was different.

The cause: as_completed returns data out of order (possibly). This leads to random row shuffling of uw_data.

Still not quite sure how doing the single worker didn't fix this when we checked earlier.

(Also: I missed adding separate options to the CLI in the last PR)