Closed dbaston closed 2 months ago
Hello Dan. I don't know if it's the correct place to ask. I can move it to issues if preferred. Do you plan to expose this functionality to Python API? I'd make use of this in the QGIS plugin as right now I have no way of reporting to user progress of calculating stats.
Yes, I would expose it to Python. I am wondering if I should also extend it to directly provide a progress percentage.
It would be nice to have that as well. I wonder how it would work in Python API.
Am I thinking about it correctly?
@JakubCha Currently yes, the progress callback is invoked either once per feature or once per raster chunk. In the per-chunk case, the caller has no simple way to know how many chunks there will be, so I've updated the progress bar to take two arguments: the fraction completed, and an informational message. This would also allow providing more frequent progress updates when a feature needs to subdivided to limit memory usage, or when a raster chunk has many intersecting features.
Codecov Report
Attention: Patch coverage is
86.56716%
with18 lines
in your changes missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #128 +/- ## ========================================== + Coverage 90.52% 90.73% +0.20% ========================================== Files 85 85 Lines 6082 6176 +94 Branches 611 611 ========================================== + Hits 5506 5604 +98 + Misses 544 540 -4 Partials 32 32 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.