isciences / exactextract

Fast and accurate raster zonal statistics
Apache License 2.0
255 stars 33 forks source link

Python: Pass NODATA values to Python functions #146

Closed dbaston closed 2 weeks ago

dbaston commented 3 weeks ago

Resolves #136. Both values and weights will be masked arrays.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.98%. Comparing base (bf8315a) to head (f4371dd). Report is 1 commits behind head on master.

Files Patch % Lines
src/raster_stats.h 96.15% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #146 +/- ## ========================================== + Coverage 90.95% 90.98% +0.03% ========================================== Files 85 85 Lines 6332 6358 +26 Branches 622 627 +5 ========================================== + Hits 5759 5785 +26 Misses 541 541 Partials 32 32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dbaston commented 2 weeks ago

@JakubCha is this change OK on your end?

JakubCha commented 2 weeks ago

@JakubCha is this change OK on your end?

@dbaston checked with the current lib version after the merge and it seems to be fine in the plugin. As long as NODATA is correctly defined in the raster metadata, the plugin will return NULL if there are no valid pixels.