Closed theroggy closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.03%. Comparing base (
8bec482
) to head (6e7e53a
). Report is 11 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks, these look like good changes to me. Do you intend to have it marked as "draft" ?
Thanks, these look like good changes to me. Do you intend to have it marked as "draft" ?
Yes, I'm still reading the docs, so might encounter other small things
I also wasn't 100% sure about the syntax for the link to "Avalable operations", so wanted to verify when docs were built in this PR... and apparently there is something wrong: the link works in the standard API reference page but it doesn't in the autoapi generated one, probably because it is deeper in the directory tree there... Still need to look into that...
Looks good now
Looks good now
Indeed, now the link works in both situations...
Thanks for the careful review and corrections!
exact_extract
:ops
.strategy
.default_value
anddefault_weight
: reference https://github.com/isciences/exactextract/issues/147#issuecomment-2310699532