search

iscoe / dragonfly

NER annotation tool
Apache License 2.0
9 stars 3 forks source link

Multi token update #15

Closed cabishop closed 5 years ago

cabishop commented 5 years ago

Issue: Undo does not remove first element highlight Solution: Add different visual indicator for first token/last token selection

cash commented 5 years ago

You aren't using semi-colons at the end of your lines. While JavaScript can infer where the semi-colons should go so they are not strictly required, leaving them out can lead to odd bugs. I prefer to use them.

Here is an example:

const a = 1
const b = 2
const c = a + b
(a + b).toString()

That results in an error because JavaScript thinks the 3rd line is const c = a + b(a + b).toString()