iscumd / Ohm2017

An obstacle course navigating robot

4 stars 4 forks source link

Added gps node #23

Closed mattjay1024 closed 7 years ago

mattjay1024 commented 7 years ago

GPS node driver. Publishes position, heading, and status.

15

EpicWolverine commented 7 years ago

I'd really prefer you to change the package name to something like vn300.

EpicWolverine commented 7 years ago

Also update ReadMe.md with instructions for installing the library and include those changes in this pull request.

EpicWolverine commented 7 years ago

This is really good, but I would still really like the name changed before merging.

EpicWolverine commented 7 years ago

Just fix the readme to the point that people can install and run this just by following its instructions and I'll merge.

danvanden commented 7 years ago

MATT JUST DO IT!!!!!

mattjay1024 commented 7 years ago

Isn't this already merged

danvanden commented 7 years ago

It is still under pull requests.

On May 31, 2017 2:36 PM, "Matthew Abraham" notifications@github.com wrote:

Isn't this already merged

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iscumd/Ohm2017/pull/23#issuecomment-305278095, or mute the thread https://github.com/notifications/unsubscribe-auth/AYWYU95pwt_Iub1M-X8nsGurMUxFRIEyks5r_bMfgaJpZM4MZk3f .

EpicWolverine commented 7 years ago

It'll get merged when you fix the readme

mattjay1024 commented 7 years ago

Updated README to fix installation issues. Plz merge.