iscyng / pe

0 stars 0 forks source link

Incorrect error prompt #4

Open iscyng opened 5 months ago

iscyng commented 5 months ago

When adding recipes with a large cook time, it tells me to enter an integer from 1 onwards even when my input is a positive one.


add rice, 10000000000000000000, 100000000000000000000, egg, dinner, www.rice.com

Make sure you enter an integer from 1 onwards for cook time!

Could be improved to give a more accurate error prompt.

Screenshot 2024-04-19 at 16.42.42.jpg

soc-se-bot commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add recipes with long cook time and a lot of calories seem to fail

Numbers above a certain calories or cook time seem to fail, not sure if it's as intended.

Also, the error message may be wrong as it suggest only > 1 onwards then it may work.

The user guide also did not specify the limitations of the cook time or calories.

image.png


[original: nus-cs2113-AY2324S2/pe-interim#2488] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

There is some implementation of a reasonable range of calorie and cook time inputs, but I believe there is some wrap around after a certain max_int, causing the app to read it as negative. Thanks for pointing this out.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]