iscyng / pe

0 stars 0 forks source link

Allows for invalid urls to be input #7

Open iscyng opened 3 months ago

iscyng commented 3 months ago

Allowed invalid website to be input

add bad website, 100, 100, none, lunch, http://www.internic.ndsahdiuoshadioawhdoihwdi/

Woo hoo chef! I have added this recipe to your recipe book: bad website / 100 kcals / 100 mins / added on 2024-04-19 / url: http://www.internic.ndsahdiuoshadioawhdoihwdi/ You now have 28 recipes in your recipe book. Keep adding some!

Storage client says: Successfully saved recipe book.

Screenshot 2024-04-19 at 17.03.49.jpg Screenshot 2024-04-19 at 17.04.11.jpg

nus-pe-bot commented 3 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Adding invalid domain works

In the user guide, the team specified that the domain added must be of a valid one, and contain the recipe.

image.png

However, I'm able to add an invalid domain which does not exist.

image.png


[original: nus-cs2113-AY2324S2/pe-interim#2493] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Sure, we could have added more validation, thanks

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Again same as the previous, don't really think that it is merely a cosmetic issue here based on the background of the app. Recipe.io saves recipes by specifying/filtering the name/calorie/allergies/cooktime, not the specific recipes. The main goal for users is that they want to get the step-by-step recipe when they want to cook. Since Recipe.io does not include that, they must copy the url and input it in the browser to view the actual recipe. This means that any changes/mistakes entered to the url will render that recipe useless. Also to add since there is no edit recipe function, any mistake when entering a input (which are usually long given the use case of Recipe.io) will lead to the user having to delete and type in the long input again and can be very inconvenient since most people are poor typers and will make mistakes. eg. add burger, 30, 500, dairy, lunch, https://www.bbcfoods.com