iscyng / pe

0 stars 0 forks source link

Allows recursive calling #8

Open iscyng opened 3 months ago

iscyng commented 3 months ago

When i recursively call the command it acts as though the url is correct.


add recursive call, 15, 15, none, lunch , https://www.recursive.com; detail 1; delete 1

Woo hoo chef! I have added this recipe to your recipe book: recursive call / 15 kcals / 15 mins / added on 2024-04-19 / url: https://www.recursive.com; detail 1; delete 1 You now have 27 recipes in your recipe book. Keep adding some!

Storage client says: Successfully saved recipe book.

Screenshot 2024-04-19 at 17.07.31.jpg Screenshot 2024-04-19 at 17.07.38.jpg

nus-pe-script commented 3 months ago

Team's Response

Sure, this seems to be a url that we should reject (duplicate issue due to URL validation)

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Adding invalid domain works

In the user guide, the team specified that the domain added must be of a valid one, and contain the recipe.

image.png

However, I'm able to add an invalid domain which does not exist.

image.png


[original: nus-cs2113-AY2324S2/pe-interim#2493] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Sure, we could have added more validation, thanks

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Agree that it is duplicate of the other bug :)