search

isds-neu / PhyCRNet

Physics-informed convolutional-recurrent neural networks for solving spatiotemporal PDEs
MIT License
108 stars 34 forks source link

A question about the code #17

Open emmmmmmmmmmmmmmmmmmmmm opened 8 months ago

emmmmmmmmmmmmmmmmmmmmm commented 8 months ago

Hello! Thanks for sharing the code. I have a small question about the code.

In line 431, you write for time_batch_id in range(num_time_batch):, but the number of num_time_batch is 1, as calculated by num_time_batch = int(time_steps / time_batch_size_load) in line 610. This means the code only calculates the first step. Is there something wrong with the code or my understanding?

I am looking forward to your early reply.

paulpuren commented 7 months ago

Hello! Thanks for sharing the code. I have a small question about the code.

In line 431, you write for time_batch_id in range(num_time_batch):, but the number of num_time_batch is 1, as calculated by num_time_batch = int(time_steps / time_batch_size_load) in line 610. This means the code only calculates the first step. Is there something wrong with the code or my understanding?

I am looking forward to your early reply.

Hi, the num_time_batch was initially set up for batch processing in ConvLSTM, where batch processing for time sequence data is slightly different from the image data. But for the numerical cases in this paper, there is no memory issue on our Nvidia V100 server so we define it as 1. If you have GPU memory issues, you may set it as 2 or 4, etc.