isettools Pass I Part II

[jenmaxwell]

This check-in covers sections of ISETTOOLS for color, image, main, and metrics.

• imageVernier

  • [ ] Review: Why are barColor and bgColor's parameter specifications done differently? (Same result)

• image1d

  • [ ] Review: Why is there no parameter checking? (Even noted within the function itself)

• sumGauss

  • [ ] Investigate: There is likely a better way to do this (re: params)? Should it be investigated?

• ISO12233

  • [ ] Review: Output definitions. (Need to determine what the output variables actually mean, as my guesswork at definitions is NOT ideal)
  • [ ] Investigate: Should we consolidate this function?
  • [ ] Assign: Assign someone to complete the TODOs (L423, L452)
  • [ ] Investigate: Better way to handle needs than the bog of 3 nested for loops (getoecf)

• ieSessionGet

  • [ ] Assign: Example cannot stand alone (no existing figures). Assign someone to flesh it out.
  • [ ] Review: Check over adjustments to function, I am particularly concerned with this one.
  • [ ] Review: Several instances of HJ - more comments later. (can we get these fleshed out?)
  • [ ] Review: Changes to parameters to support existing documentation.

• ieSessionSet

  • [ ] Investigate: Need to add in the key/values section.
  • [ ] Assign: Example cannot stand alone (newAlg, hObject, etc... are not defined). Assign someone to fix.
  • [ ] Review: Review coding changes for accuracy
  • [ ] Assign: Assign someone to complete the Programming TODO.