isettools Pass I Part IV

[jenmaxwell]

This check in covers additional sections of rgc, including: tests, @ rgcMosaic, @ rgcLNP, @ rgcGLM, and @ rgcLayer

• /tests/s_rgcGridNtrial

  • [ ] Assign: Assign someone to complete the programming TODO

• /@ rgcMosaic/spatialArray

  • [ ] Review: The included text did not refer to the existing function. Please check if my changes are correct for the current function

• /@ rgcMosaic/set

  • [ ] Assign: Assign someone to check over my text additions, particularly added content for the param option explanations.
  • [ ] Investigate/Assign: Fill in missing types for param options, as well as several missing explanations I was unable to decipher. Determining the missing key/value pairs section would also be helpful.
  • [ ] Assign: Assign someone to fix the examples, as uninitiated variables will cause it to fail

• /@ rgcMosaic/rgcMosaic

  • [ ] Assign: Assign someone to fix the examples - uninitiated variables will cause it to fail.
  • [ ] Assign: Assign someone to fill in the missing key/values section

• /@ rgcMosaic/plot

  • [ ] Review: Should we clean up some of this commentary?
  • [ ] Review: Please check added text for accuracy

• /@ rgcMosaic/inputPositions

  • [ ] Review: I'm worried I mis-copied the description section, please check it for cohesion

• /@ rgcMosaic/initSpace

  • [ ] Investigate: If all three arguments are required (compared to being able to operate using default values) then the text (and input parser sections) need to be updated. Is this the case?
  • [ ] Review: Added parameters are not dealt with until the end? Why are these handled so far away from the rest of the parsing section?

• /@ rgcMosaic/get

  • [ ] Assign: Assign someone to fill in the missing key/values section
  • [ ] Assign: Assign someone to fix the example (uninitialized variables mean it'll fail)

• /@ rgcMosaic/computeSeparable

  • [ ] Investigate: Answer BW's question (L138): nTrialsLinearResponse is not allocated before the loop, so it grows organically through execution, which takes a bit more time during the loop, as well as more space -- which is what MATLAB is calling out here.

• /@ rgcLNP/set

  • [ ] Assign: Assign someone to fix the example (uninitialized variables will cause it to fail) - also I believe this is using the wrong set command?
  • [ ] Assign: Assign someone to add the missing key/values section (no params listed in parsing, so they're missing there as well).

• /@ rgcLNP/rgcLNP

  • [ ] Assign: Assign someone to fill in the missing key/values section (main & constructor)
  • [ ] Assign: Assign someone to fix the example. ir needs to be initialized.

• /@ rgcLNP/get

  • [ ] Assign: Assign someone to add the missing key/values section
  • [ ] Investigate: Determine missing information for couplingFilter and couplingMatrix parameters. I could not find them in the parent class at all.
  • [ ] Assign: Assign someone to fix the example, will not work without being initialized.

• /@ rgcLayer/set

  • [ ] Assign: Assign someone to review my added text, particularly for the parameter options.

• /@ rgcLayer/plot

  • [ ] Assign: Assign someone to fix the example (instantiate)

• /@ rgcLayer/normalize

  • [ ] Review: Shouldn't we add some sort of parameter checking here?
  • [ ] Assign: Assign someone to review added/changed content

• /@ rgcLayer/get

  • [ ] Assign: Determine which key/value pairs should be supported, and add them.

• /@ rgcLayer/compute

  • [ ] Assign: Assign someone to fill in the missing notes section on rgcLNP needs to be added.
  • [ ] Assign: Assign someone to fix the example - instantiate rgcL.

• /@ rgcGLM/set

  • [ ] Assign: Assign someone to add the desired key/values section as well as the associated code for it.
  • [ ] Assign: Assign someone to fix the examples, via instantiating the required variables.

• /@ rgcGLM/get

  • [ ] Assign: Assign someone to fix the examples, via instantiating the required variables.