search

ish-app / ish

Linux shell for iOS
https://ish.app
Other
16.56k stars 873 forks source link

Cursor is not at the right place when using custom font JetBrains Mono #1485

Open jimzenn opened 3 years ago

jimzenn commented 3 years ago

When using JetBrians Mono, the cursor would be offset to the right by a few characters. Not sure if this is unique to this font.

Screenshot 2021-07-04 at 9 38 06 PM

tbodt commented 3 years ago

Could you use TestFlight and test this on version 1.2.1 of the app? There's been a change in hterm since then that might have caused this.

jimzenn commented 3 years ago

I need access for TestFlight. How can I be a part of the test program?

tbodt commented 3 years ago

The link in the readme should work: https://testflight.apple.com/join/97i7KM8O

jimzenn commented 3 years ago

Unfortunately the issue is not resolved with the TestFlight version.

I’m using iSH 1.2.2, iPad Pro (11-inch) (3rd generation), iPadOS public beta 1

Screenshot 2021-07-04 at 9 54 23 PM

jimzenn commented 3 years ago

I also tested with Pragmata Pro, it also has the same issue.

tbodt commented 3 years ago

Ah, I was asking you try with an older version, as it might have broken in the latest version. Try version 1.2.1. It should still be available on testflight, under Previous Builds.

jimzenn commented 3 years ago

Ah ha you are right, with version 1.2.1 the issue is not present.

warvette commented 2 years ago

Ah, I was asking you try with an older version, as it might have broken in the latest version. Try version 1.2.1. It should still be available on testflight, under Previous Builds.

1.2.1 has expired. Anyway to get it back or just be patient for the fix in a new release?

PeterBuchHansen commented 2 years ago

It is the same problem for other monospaced fonts I have tried ‘MesloLGF NF Regular’ , ‘ Ubuntu Mono derivative Powerline’ and ‘3270-Medium Nerd Font Complete Mono’

plz fix it

PeterBuchHansen commented 2 years ago

Ah, I was asking you try with an older version, as it might have broken in the latest version. Try version 1.2.1. It should still be available on testflight, under Previous Builds.

I have scoured the net and it is true it didn’t seem to be a problem in version 1.2.1 sadly it’s not available in TestFlight longer

saagarjha commented 2 years ago

A fix (well, partial revert, really) should be int the latest TestFlight beta.

warvette commented 2 years ago

A fix (well, partial revert, really) should be int the latest TestFlight beta.

Latest TestFlight beta works perfectly! Thank you so much.

16E83EB6-3A1B-4268-8CDF-E60CE11DF715

140E214B-9D39-41B4-820A-C0E9150FB367

bassu commented 2 years ago

The cursor offset is fixed in beta version 1.2.3 build (292).

Reference https://github.com/ish-app/ish/issues/1579#issuecomment-981979331