Trades can leave teams unbalanced

ishakir / shakitz-fantasy-football

The open source fantasy football application!

Eclipse Public License 1.0

37 stars 11 forks source link

Trades can leave teams unbalanced #32

Open ishakir opened 10 years ago

ishakir commented 10 years ago

Things to do to fix:

Work out why inactive players can become active when swapping
Move game_week_team validation code into model
- Number of players in team & benched
- Distribution of players amongst QBs, RBs etc...
Remove it from any controllers where it shouldn't belong and handle errors correctly
- In case this happens again
- Work out how to handle the dynamic nature of trades over time
- Do we allow trade offers that will mean team selection isn't possible? (As further changes might be made to make it possible in future)
- We reject accepting trades that will mean team selection isn't possible

ishakir commented 10 years ago

Tracked this down, the code to change the playing status of each player hasn't been changed

MikeSpitz commented 10 years ago

That would fix the uneven numbers of playing/non-playing. Further investigation is needed to see if the person would be able to fix their team if it's currently invalid though. I don't think they would be able to at the moment due to how the front-side validation works. This would be fixed by what we discussed: having a method that automatically declares the first valid team for a user

ishakir commented 10 years ago

I agree, I will do the simple fix when I get around to it, at least that will avoid the 11 / 7 player split

MikeSpitz commented 9 years ago

The issue mentioned in November regarding the front side validation should no longer be an issue after the recent refactoring in 7b96e4a .

Not sure what the simple fix you eluded to was though but I think you were in the middle of refactoring this all anyhow.