search

ishakir / shakitz-fantasy-football

The open source fantasy football application!
Eclipse Public License 1.0
37 stars 11 forks source link

Kyle Orton hasn't appeared #35

Closed ishakir closed 9 years ago

ishakir commented 10 years ago

On the currently running site there is no player called K.Orton and nothing like that on the buffalo bills page. We should work out why this is...

ishakir commented 9 years ago

A bit of output from some investigation I did into this. The nflgame python API returns Orton's position as the empty string, and as such he is discarded when we filter out all the players that aren't the types that we use:

S.Gostkowski K NE Cha.Jones DE NE F.Jackson RB BUF K.Orton BUF J.Casillas OLB NE L.Smith TE BUF V.Wilfork DT NE

ishakir commented 9 years ago

I'm not really sure what we get do about this except keep an eye on it and if there's a player that is a real problem, make an exception for them in the python and upload anyway. Unless you have a better idea.

MikeSpitz commented 9 years ago

This bug is probably invalid with the coming season (unless it happens again) but we need to implement a test that essentially just checks that the number of players we generate equate to the number of players

ishakir commented 9 years ago

Yeah going to close this