ishakir / shakitz-fantasy-football

The open source fantasy football application!
Eclipse Public License 1.0
37 stars 11 forks source link

Bench of the Week table doesn't sort #48

Closed ishakir closed 9 years ago

MikeSpitz commented 9 years ago

This isn't working because we are dynamically adding the table rows after page load. I would suggest moving out the logic from the coffee script file and using the Rails ERB system to input the information into the table like is currently done on the user/home.html.erb .

That will ensure that the table has all the data it needs so it would be sortable at page load. It should also stop the delay users get when going on the stats page in seeing the bench table, which isn't great.

ishakir commented 9 years ago

Yeah, need to put this into assigns, rather than making calls from javascript. When I do that I'll remember to make sure that stats displayed (other than total bench points) are only shown if the game week they're associated with is finished.

MikeSpitz commented 9 years ago

Fixed in 6012c09a7d900bdd58cffeefd36e0c1d20043b47