ishan-agarwal-05 / pe

0 stars 0 forks source link

Case Sensitivity of names #7

Open ishan-agarwal-05 opened 4 days ago

ishan-agarwal-05 commented 4 days ago

The name matching for duplicates is case sensitive even in the case of matching email and phone number, which is logically flawed. A client having the same name, email and number with just 1 dfference in case is still not considered as duplicate

Screenshot 2024-11-15 at 5.19.07 PM.png

Example is index 3 and 4 David Li / David li

nus-se-script commented 1 day ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

According to the User Guide, there is a section called Duplicate Client Detection. This shows the way our application detects duplicated clients.

A client is only considered duplicated if and only if all three parameters NAME, PHONE_NUMBER and EMAIL_ADDRESS are exactly the same (including case sensitivity).

image.png

However, we believe it can be better, hence we will classify as NOT-IN-SCOPE. In addition, it is not meant to be as fixing it is less important than the work done in the current version of the product e.g., it was not related to features delivered in v1.6 or lower priority than the work already done in v1.6.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]