search

ishan9299 / nvim-solarized-lua

solarized colorscheme in lua for nvim 0.5
MIT License
184 stars 54 forks source link

All highlighting stopped working with neovim 0.8 #52

Closed rbjorklin closed 2 years ago

rbjorklin commented 2 years ago

There seems to have been some breaking changes in the new 0.8 release.

erikw commented 2 years ago

When using nvim 0.8 + master on nvim-treesitter, highlights are not working anymore. It seems that all colorschemes needs to be updated.

See https://github.com/nvim-treesitter/nvim-treesitter/issues/3680

rbjorklin commented 2 years ago

Looks like the colorscheme is actually okay and the real problem is that filetype detection has stopped working. If I do :set ft=ocaml the highlighting works just fine.

rbjorklin commented 2 years ago

@erikw I fixed my highlighting issues by removing these bits from my config. As it turns out lua filetype detection is the default in neovim 0.8. I have also tweaked the colorscheme a bit in #54, give it a spin and let me know what you think!

@ishan9299 any chance you could review and possibly merge this?

Dieterbe commented 2 years ago

@rbjorklin i'm glad i found your issue! per the 0.7 announcement on the blog i had added these lines to my config:

-- new filetype part of 0.7: https://neovim.io/news/2022/04
vim.g.do_filetype_lua = 1
vim.g.did_load_filetypes = 0

your assesment is spot on, but also surprising, that the upgrade to v0.8 requires a removal of such config. i expected the transition from "opt-in" to "by default" be a bit smoother. either way, thanks to dev team for all their hard work!