Closed hugovk closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/ishandeveloper/githubwrapped/dxenv8lv4
✅ Preview: https://githubwrapped-git-fork-hugovk-patch-3.ishandeveloper.vercel.app
Hey @hugovk I actually addded that '+' symbol because there might be times when the api does not reflect the latest numbers, as I've set a cache-header for a duration of 30mins, to help reduce the number of requests, in case someone tries to generate their report multiple times.
Therefore, I'm afraid. I won't be merging this PR. Feel free to comment If you disagree and we can discuss :)
Hi!
Yes, I get the reason, it's about using both "over" and the plus, they're both saying the same thing.
For example:
I made over 614+ commits
It doesn't make sense to say over and plus. Either of these is better:
I made over 614 commits
Or
I made 614+ commits
The same goes for the factbox:
So far, Over 1.9 Billion+ commits have been made towards open-source this year.
"Over 1.9 Billion+" doesn't really make sense. Use either:
So far, over 1.9 billion commits have been made towards open-source this year.
or:
So far, 1.9 billion+ commits have been made towards open-source this year.
I also fixed the miscapitalisation of Over and Billion.
Thanks!
No need for both "Over" and the plus in: