search

ishanvyas22 / asset-mix

Provides helpers functions for CakePHP to use Laravel Mix.
MIT License
32 stars 12 forks source link

Strip querystring from asset path so mix manifest key matches filename #40

Closed jrbakooba closed 2 years ago

jrbakooba commented 2 years ago

Resolves #39

jrbakooba commented 2 years ago

Whoops @ishanvyas22 I apologize, looks like my code formatters ran automatically. Let me know if you want me to revert those formatting changes.

ishanvyas22 commented 2 years ago

Whoops @ishanvyas22 I apologize, looks like my code formatters ran automatically. Let me know if you want me to revert those formatting changes.

Yup, pls revert it.

jrbakooba commented 2 years ago

Apologies for the delay. I have added two tests for checking stripping the query string.

I also reverted all the formatting changes.

jrbakooba commented 2 years ago

Oh, I see phpstan has something to say as well. I will fix that.

ishanvyas22 commented 2 years ago

Thanks @jrbakooba