Closed JPDevelop closed 1 year ago
In handlers.py:133 there are the following lines:
handlers.py:133
if api_key != request.app.state.api_key: raise HTTPException(status_code=status.HTTP_403_FORBIDDEN)
This piece of code is vulnerable to a timing side channel attack and should be replaced with the constant time comparison method hmac.compare_digest
@JPDevelop very nice! wanna make a PR?
Closing as this became redundant with: https://github.com/ishefi/semantle-he/commit/3e898f59ca1ec816a4544ae8079988832b7c2a2d
In
handlers.py:133
there are the following lines:This piece of code is vulnerable to a timing side channel attack and should be replaced with the constant time comparison method hmac.compare_digest