Closed cmtg closed 1 year ago
Merging #256 (fe503b6) into master (0805bbf) will increase coverage by
0.01%
. The diff coverage is100.00%
.:exclamation: Current head fe503b6 differs from pull request most recent head e7a0a92. Consider uploading reports for the commit e7a0a92 to get more accurate results
The PR looks GREAT! Thanks, very good job.
My only question is: I see you included a new repo in test-repos.zip
, and the size went up 180% (+25Mb). So I imagine you included a large repo. Would it be possible to create a small repo? I think (BIG assumption here) you can play with the date of your PC (like make a commit, change the date of your PC to another timezone, make another commit, change it back, etc...).
If it's not possible no worries, I will land it as is and will try to come up with something else 👍
Somehow test-repos/
got inflated. So I downloaded the zip file from the GitHub, added the since_as_filter/
repository again and zipped everything.
Now it should be fine (file size: 31Mb).
Thanks for catching this.
Added
since_as_filter
so that all commits greater than thesince_as_filter
date are considered, even if committer dates are out of order (see https://github.com/ishepard/pydriller/issues/255).