ishepard / pydriller

Python Framework to analyse Git repositories
http://pydriller.readthedocs.io/en/latest/
Apache License 2.0
809 stars 139 forks source link

Added since_as_filter #256

Closed cmtg closed 1 year ago

cmtg commented 1 year ago

Added since_as_filter so that all commits greater than the since_as_filter date are considered, even if committer dates are out of order (see https://github.com/ishepard/pydriller/issues/255).

codecov[bot] commented 1 year ago

Codecov Report

Merging #256 (fe503b6) into master (0805bbf) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head fe503b6 differs from pull request most recent head e7a0a92. Consider uploading reports for the commit e7a0a92 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/ishepard/pydriller/pull/256/graphs/tree.svg?width=650&height=150&src=pr&token=hDdmGET6SJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Davide+Spadini)](https://codecov.io/gh/ishepard/pydriller/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Davide+Spadini) ```diff @@ Coverage Diff @@ ## master #256 +/- ## ========================================== + Coverage 97.11% 97.12% +0.01% ========================================== Files 15 15 Lines 1040 1045 +5 ========================================== + Hits 1010 1015 +5 Misses 30 30 ``` | [Impacted Files](https://codecov.io/gh/ishepard/pydriller/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Davide+Spadini) | Coverage Δ | | |---|---|---| | [pydriller/repository.py](https://codecov.io/gh/ishepard/pydriller/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Davide+Spadini#diff-cHlkcmlsbGVyL3JlcG9zaXRvcnkucHk=) | `93.06% <ø> (ø)` | | | [pydriller/utils/conf.py](https://codecov.io/gh/ishepard/pydriller/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Davide+Spadini#diff-cHlkcmlsbGVyL3V0aWxzL2NvbmYucHk=) | `96.13% <100.00%> (+0.10%)` | :arrow_up: |
ishepard commented 1 year ago

The PR looks GREAT! Thanks, very good job.

My only question is: I see you included a new repo in test-repos.zip, and the size went up 180% (+25Mb). So I imagine you included a large repo. Would it be possible to create a small repo? I think (BIG assumption here) you can play with the date of your PC (like make a commit, change the date of your PC to another timezone, make another commit, change it back, etc...).

If it's not possible no worries, I will land it as is and will try to come up with something else 👍

cmtg commented 1 year ago

Somehow test-repos/ got inflated. So I downloaded the zip file from the GitHub, added the since_as_filter/ repository again and zipped everything.

Now it should be fine (file size: 31Mb).

Thanks for catching this.