ishitaraina1807 / Reading-Matters

A BookFinder App
https://searchbooks.vercel.app
MIT License
25 stars 14 forks source link

Issue: Error parsing is not optimal. #1

Open Sahil-Chhoker opened 3 months ago

Sahil-Chhoker commented 3 months ago

Error parsing on the signup page is very vague. Issues:

  1. Does not tell us about the email if it is already used.
  2. Does not tell us if the email is wrong.
  3. Does not tell us if the account already exists.
ishitaraina1807 commented 3 months ago

Hello sahil, you can start working in your issues. Thanks for raising these. When you make the pull request make sure you tag the issue number.

Sahil-Chhoker commented 3 months ago

Yeah i am okay to work on the issue, but i need some information about the layout of your project. You mind telling me where exactly are you doing the error parsing for email?

ishitaraina1807 commented 3 months ago

Sure @Sahil-Chhoker. I has been done in Auth folder - for both signup and login. Clone and try to understand the project. If you face any issue, then please feel free to contact.

Sahil-Chhoker commented 3 months ago

I think you should provide some info about setting up the project, like am i supposed to make a .env file for all the api keys? And how do i set up the firebase auth and firestore?

ishitaraina1807 commented 3 months ago

I have provided the necessary details, kindly refer to youtube videos, setting up firebase isn't something I will teach you.

Sahil-Chhoker commented 3 months ago

Main issue wasn't the setting up of firebase though, i asked where do the api keys go.

ishitaraina1807 commented 3 months ago

Navigate to firebase.js in component folder. API is not wrapped in .env file.

Shahbaz898414 commented 2 months ago

can you assign me this issue?