ishitasrivastava97 / MI-449-js-collect-and-display-information

0 stars 0 forks source link

Project Feedback #1

Open ishitasrivastava97 opened 3 years ago

ishitasrivastava97 commented 3 years ago

Build a dating profile generator

@egillespie Can you please take a look at this? It's hosted here and meets the following criteria:

egillespie commented 3 years ago

Your solution is working really well, Ishita! In fact, the only requirement missing is the last one. Would you mind installing the linter using the instructions from the lesson to identify the issues and fix them?

Comment back when you're ready for me to take another look! 🎉

ishitasrivastava97 commented 3 years ago

Hi! I had installed the linter initially, and it was recommending I use let or const instead of var for my variables. I thought these were just suggestions and not major errors (as nothing else was underlined), but I have changed them now. Could you please let me know if this is the error you meant? Otherwise I can go back and try reinstalling Lint. Thank you

egillespie commented 3 years ago

Yep, those are the issues I meant! The var keyword has some really strange side-effects that tend to pop up in later lessons so I try to discourage using it when I can. 😉

Your changes look good. Outstanding work on this project! 💯 :shipit: