search

ishitatsuyuki / acominer

An experimental ETH miner powered by Vulkan
Apache License 2.0
18 stars 6 forks source link

bump dependencies and use compiler optimizations #3

Closed Titaniumtown closed 2 years ago

Titaniumtown commented 2 years ago

Does as the title says. This PR bumps dependencies in Cargo.toml, alongside enabling thin LTO and O3 optimizations when building for release.

ishitatsuyuki commented 2 years ago

Thanks for the contribution. But sorry, I'm not a fan of this.

On the dependencies: there is no need to update them right now. I do update those once in a while, but these aren't really the core part of this tool and updating them provides no benefit.

On optimizations: while LTO and codegen-units=1 does produce better optimized code, they don't really benefit this tool since it's completely GPU-bound. The CPU usage of this is ~0.3% on my computer, which means that optimization won't make any measurable difference.