search

ishkawa / APIKit

Type-safe networking abstraction layer that associates request type with response type.
MIT License
2k stars 205 forks source link

[question] Was develop/4.0 branch abandoned? #272

Open hiroshi opened 5 years ago

hiroshi commented 5 years ago

I'm trying to update an app that depended on APIKit 4.0.0-beta.1 (swift 3) to current swift version. The app is using progressHandler. However, 4.0.0-beta.1 tag is on develop/4.0 branch. It seems that the branch is not merged into master and latest release tag 5.0.0.

ikesyo commented 5 years ago

I'm not sure about that development branch/the beta tag.

@ishkawa Could you clarify this?

hiroshi commented 5 years ago

Thanks for your response, @ikesyo.

Just FYI, I'm trying to merge current master into the develop/4.0 branch. https://github.com/hiroshi/APIKit/tree/develop/4.0 Some tests are still failing so far... Also, the app is not worked with Xcode 10.2.1 yet for other reasons... I'll report if it works or failed....

Anyway, the progressHandler feature is not being to be merged in the main line, maybe I need to migrate to other solutions though... (I don't mean to blame any of it. ;-)

davdroman commented 4 years ago

There are some PRs that went into develop/4.0 that never made it to master, for example #230. If the branch was abandoned, it'd be good to at least move all the missing commits to master for the next major release, since some of them are extremely useful features.

417-72KI commented 4 years ago

Any updates?