search

ishovkun / SierraBreeze

OSX-like window decoration for KDE Plasma written in C++
356 stars 40 forks source link

[Suggestion] Some ideas for enhancement #21

Open atolstoy opened 6 years ago

atolstoy commented 6 years ago

First, many thanks for this great Kwin decoration! There are few things I'd like to suggest: Make corner rounding configurable Let users change window buttons colours. Why not create a matching Qt5 style or at least apply custom stylesheets to Breeze (like, making button paddings smaller)?

Please take a look at DSP: https://www.deviantart.com/art/DSP-shell-tar-546283883 It looks very nice although there are few odds and inconsistencies that you can discover after a while. Having a better macOS-inspired style would just great!

ishovkun commented 6 years ago

@atolstoy I thought about the colors... The thing is that I want to later extend the theme to contain various decoration styles. I'm not sure yet to unify the customization options with the enhancements that I plan. But I am keeping this open since it's a good suggestion.

Regarding DSP, I will try to look into that later as well.

MarianArlt commented 6 years ago

Custom corner radius is probably nice although I don't think it's that important for most users. Also it's very easily changed in breeze.h before compiling. (Since all of this needs to be compiled anyways) Custom colors are something I feel that most people will tweak to weird values and have overly customized OSes. And although I could rant about the MacOS buttons size and saturation choice all day it's as well easily changed in breezebutton.cpp if you really needed it.

Personally I would like to see the color of the drawn button elements integrate with their buttons color. Maybe just change it to black and setAlpha? As it is it looks like it's taking its color uniformly from the title bar itself. From browsing your modifications I can see that you completely redrew the button elements. This has the ugly side effect that the hover backgrounds of breeze still work and produce mixing anti-aliasing of the different colors at the buttons edge. For my personal use I am playing around with this at the moment.

Also as mentioned in this request people would probably like a changing color for hover and/or pressed status. I personally prefer lighter, the thread starter says darker. This could be a Qt slider option with negative valus to the left and positive valus to the right changing the brightness of the color respectively. This is probably a lot of work though and may not be an arguable option.