search

ishovkun / SierraBreeze

OSX-like window decoration for KDE Plasma written in C++
355 stars 40 forks source link

Background colors and icons rewritten #25

Closed MarianArlt closed 6 years ago

MarianArlt commented 6 years ago

Defining the QColor of the button inside of the respective DecorationButtonType:: element results in the original breeze background logic appear underneath your modifications. This leads to bad anti-aliasing.

I rewrote the colors to be defined in the Button::backgroundColor() const just like the original breeze decorations do and implemented isHovered() and isPressed() states respectively which would solve #23.

This needed further changes in Button::foregroundColor() const to play well together. I also adjusted the hint size by one pixel for each button so they won't appear too big.

As mentioned in the file the colors are hard coded. They should instead be defined as variables, but I'm not that much of a C++ neither a Qt expert.

ishovkun commented 6 years ago

@MarianArlt I like what you did with the button modification on pressed, but why did you have to change the hint for the maximize button? It's now not Macish :-) That is why for now I have your commit. The hint pen you used is also too transparent for me. In future, I am planning to let the user select the hint style and button colors and hint style. I will get back to your proposed changes when I decide to implement that.

MarianArlt commented 6 years ago

Sorry for tweaking too much at a time, that's actually not guideline style from my part. Just implement what you need from it. I personally can't stand a lot of details from the current MacOS, I use OSX since 2006 and the latest design choices are something that, as a designer myself, I am worried about regarding their OS. As #21 suggests, it's nice to base things on others ideas, but it's even nicer to build up on it but I understand that this wants to be a well made clone. And it is indeed well done! The maximize/minimize is what I personally use and the pin actually is not well made. I hope it'll help you on your further development though. Happy coding!