search

ishovkun / SierraBreeze

OSX-like window decoration for KDE Plasma written in C++
356 stars 40 forks source link

[Suggestion] Increase/add contrast pixel #34

Open Luwx opened 5 years ago

Luwx commented 5 years ago

This is a great decoration, but when i'm using it i always feel that it is missing something.. it's too "naked".

Having a 1px dark but subtle line around the decoration makes it easy to distinguish between overlaping windows, and, imo, improve the appearance.

screenshot_20180801_223439

With contrast pixels: screenshot_20180801_223531

In the second screenshot the window has also a lighter line on the top, but with just the dark line would make it look better.

trmdi commented 5 years ago

Try changing the Shadow values in the SierreBreeze settings.

Luwx commented 5 years ago

In the screenshot the shadow already is at 50px with 40% strengh.. and using more than this doesn't make a big difference using dark themes anyways :)

RichGuk commented 5 years ago

I second this. Looks to be the way Mac Mojave will handle dark windows on top of each other too.

Also @Luwx may I ask what theme you're using there, looks nice.

Luwx commented 5 years ago

Thanks! Thats a kvantum theme that i'm making. You can download here.

Luwx commented 5 years ago

I managed to have a stronger outline by changing this line:

painter.setPen( gradientStopColor( g_shadowColor, g_shadowStrength*0.5 ) );

to:

painter.setPen( Qt::black );

It's not 100% opaque black and gives a nice result:

screenshot_20180924_203350

I don't know if this is the right way to do it, and it will be nice if someone could make a more complete aproach.

Petross404 commented 5 years ago

I managed to have a stronger outline by changing this line:

Can you please point where in the code this line is?

Luwx commented 5 years ago

I managed to have a stronger outline by changing this line:

Can you please point where in the code this line is?

Arround 780, you will see a contrast pixel comment. You can just increase the shadow strengh number instead of replace everything with qt::black, the result is the same.

Petross404 commented 5 years ago

I managed to have a stronger outline by changing this line:

Can you please point where in the code this line is?

Arround 780, you will see a contrast pixel comment. You can just increase the shadow strengh number instead of replace everything with qt::black, the result is the same.

In which file? Can you please find it in the repo and give us the link here?

domsch1988 commented 5 years ago

I managed to have a stronger outline by changing this line:

Can you elaborate how you got the decoration to be transparent on Dolphin? I really like your Kvantum theme, but at the moment, it doesn't look like your Screenshot. I'm also getting a difference in color between konsole and the decoration with this.